Skip to content

chore: clean up upvote_count_threshold experiment#5843

Merged
rebelchris merged 1 commit intomainfrom
eng-1244-clean-up-the-upvote_count_threshold-experiment
Apr 9, 2026
Merged

chore: clean up upvote_count_threshold experiment#5843
rebelchris merged 1 commit intomainfrom
eng-1244-clean-up-the-upvote_count_threshold-experiment

Conversation

@nimrodkra
Copy link
Copy Markdown
Member

@nimrodkra nimrodkra commented Apr 9, 2026 •
edited by github-actions bot
Loading

Summary

  • Removed featureUpvoteCountThreshold feature flag, getUpvoteCountDisplay() utility, and UpvoteCountDisplay interface
  • Simplified 6 consumer components (PostMetadata, ActionButtons, PostUpvotesCommentsCount, RepostListItem, PostEngagementCounts, CompanionEngagements) to show upvote counts with a simple > 0 check
  • Removed experiment-only props (showBelowThresholdLabel, userHasUpvoted, shouldEvaluateFeature) and "New" label rendering paths
  • Deleted 6 experiment-only test/spec files and cleaned up unused imports (UserVote, useConditionalFeature, useAuthContext) from components that only used them for the experiment

Test plan

  • Strict typecheck passes on all changed files
  • ESLint passes on all changed files (shared + extension)
  • 50 test suites / 419 tests pass in shared package (related tests)
  • 12 tests pass in extension package (CompanionEngagements)
  • Verify feed cards show upvote count when numUpvotes > 0
  • Verify post page shows upvote count when numUpvotes > 0
  • Verify "Be the first to upvote" message preserved in companion
  • Verify no "New" label appears anywhere

Closes ENG-1244

Created by Huginn 🐦‍⬛

Preview domain

https://eng-1244-clean-up-the-upvote-cou.preview.app.daily.dev

@nimrodkra @claude
chore: clean up upvote_count_threshold experiment
6067b2f 
The experiment showed negative results and was recommended for rollback.
Remove the feature flag, utility function, threshold logic, and "New"
label rendering from all 6 consumer components, restoring the original
upvote display behavior (show count when > 0).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 9, 2026 0:33am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 9, 2026 0:33am

Request Review

@rebelchris rebelchris merged commit 8e96db1 into main Apr 9, 2026
13 checks passed
@rebelchris rebelchris deleted the eng-1244-clean-up-the-upvote_count_threshold-experiment branch April 9, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nimrodkra @rebelchris