Feat/onboarding v2 ab test

[capJavert]

Changes

• clean branch
• does not touch any top level layout stuff (to avoid conflicts/breaking)
• does not touch original onboarding or freyja for now, we will cleanup if this wins
• behind feature tag for ab test
• also asks for elevated private repos for import (we can remove)
• only open point is error handling if we don't detect any keywords in flows

API: dailydotdev/daily-api#3775

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://feat-onboarding-v2-ab-test.preview.app.daily.dev

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
daily-webapp	Ready	Preview	Apr 8, 2026 3:56pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
storybook	Ignored		Apr 8, 2026 3:56pm

[capJavert]

@claude review

[claude]

Claude finished @capJavert's task in 2m 22s —— View job

---

Code Review

• Gather context and read changed files
• Review OnboardingV2.tsx
• Review OnboardingV2Styles.tsx
• Review useOnboardingAnimations.ts
• Review auth component changes
• Review supporting changes (featureManagement, constants, graphql)
• Post final review

---

Overall this is a well-structured A/B experiment — isolated behind a flag, ssr: false dynamic import, no layout changes. The UX flow and animation work is impressive. Below are issues worth addressing before or after ship.

---

Bugs / Correctness

1. Fire-and-forget mutation in handleExperienceLevelSelect

OnboardingV2.tsx:335 — The gqlClient.request() is not awaited and has no error handling. If this silently fails, the user's experience level is never saved:

// ❌ fire-and-forget
gqlClient.request(UPDATE_USER_PROFILE_MUTATION, {
  data: { experienceLevel: UserExperienceLevel[level] },
});

Since you're already in an async function you can await it, or at minimum .catch(console.error) for the experiment.

Fix this →

---

2. startImportFlow ignores API errors silently

OnboardingV2.tsx:279-293 — When the API call to requestGitHubProfileTags() / requestOnboardingProfileTags() fails, the code does nothing:

const [apiResult] = await Promise.allSettled([...]);
if (apiResult.status === 'fulfilled') {
  setAiPrompt('');
  setSignupContext(null);
}
// rejected → falls through to setGithubImportPhase('awaitingSeniority')
// user proceeds as if the profile was imported

The user still reaches the seniority screen without their profile being set up. At minimum, show an error state or toast.

---

3. Inner setTimeout calls in finishing phase are not cleaned up

OnboardingV2.tsx:450-462 — Only the outermost exitTimer is tracked by the useEffect cleanup. The two nested setTimeout calls fire unconditionally if the component unmounts mid-animation:

return () => clearTimeout(exitTimer); // ✅ outer only
// inner timeouts (600ms + 350ms) are leaked

Use useRef to track all three timers and clear them in cleanup.

Fix this →

---

Design / Architecture

4. OnboardingV2 not wrapped by ErrorBoundary or Toast

onboarding.tsx:375-377:

if (isOnboardingV2) {
  return <OnboardingV2 />;   // ❌ no ErrorBoundary, no Toast
}
return (
  <JotaiProvider>
    <ErrorBoundary feature="onboarding">   // ✅ V1 is protected

Any unhandled render error in V2 will crash the whole page. At minimum wrap it in <ErrorBoundary>.

---

5. featureOnboardingV2 defaults to isDevelopment

featureManagement.ts:155:

export const featureOnboardingV2 = new Feature('onboarding_v2', isDevelopment);

This enables V2 for all local dev by default. Developers working on the V1 funnel won't realize V2 is silently activated. Every other feature flag in this file defaults to false. Consider defaulting to false and having developers explicitly set it via GrowthBook SDK override.

---

6. GitHub icon SVG path hardcoded three times

The GitHub icon path (M12 2C6.477 2 2 6.477 2 12...) appears inline in the hero CTA, chooser modal, and import overlay. There's already a ChromeIcon import but no GitHubIcon usage. There is likely one in the icons package. Using it (or extracting a local GithubSvg const) removes ~60 lines of duplication.

---

7. autoTriggerProvider effect could double-fire in React StrictMode (dev)

AuthOptionsInner.tsx — The effect calls onProviderClickRef.current(autoTriggerProvider, false) on every render where autoTriggerProvider is set. In React 18 StrictMode (development only), effects run twice, meaning this fires onProviderClick twice → could trigger two OAuth redirects in dev. The ssr: false dynamic import limits blast radius to client-side only, but worth adding a guard.

---

Minor

8. mobileAppUrl uses direct URL instead of r.daily.dev redirect

constants.ts — All other external links in this file use https://r.daily.dev/... redirect URLs. The new mobileAppUrl = 'https://app.daily.dev' is inconsistent. If this is intentional (direct app store redirect), a comment would help.

9. OnboardingV2Styles rendered after feed section

OnboardingV2.tsx:1132 — <OnboardingV2Styles /> is placed after the feed renders. styled-jsx injects synchronously so FOUC is unlikely, but convention is to inject styles before the content they style.

10. usePersistentContext with undocumented 3rd argument

OnboardingV2.tsx:229-231:

const [signupContext, setSignupContext] = usePersistentContext<
  'github' | 'ai' | null
>(ONBOARDING_SIGNUP_CONTEXT_KEY, null, ['github', 'ai']);

The third argument appears to be an allowlist for hydration validation. Not documented — a comment would help readers understand why it's there.

---