fix(sql): rank window output before ORDER BY/LIMIT - #33
Draft
dai-chen wants to merge 1 commit into
Draft
Conversation
dai-chen
force-pushed
the
fix/sql-window-order-limit
branch
from
June 26, 2026 21:51
1b57fe4 to
70ff9d8
Compare
Scope the fix to the unified query API parser (ExtendedAstBuilder); fixing the shared AstBuilder directly would break the V2/legacy engine. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
fix/sql-window-order-limit
branch
from
June 26, 2026 22:21
70ff9d8 to
53958e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.