Switch our requests pin to only exclude 2.32.0 - #21996
Closed
jmsanders wants to merge 4 commits into
Closed
Conversation
Both docker-py and requests have fixes in flight. We can narrow our pin to only exclude the breaking version. docker/docker-py#3257 psf/requests#6707 (comment)
alangenfeld
approved these changes
May 21, 2024
| "fsspec<2024.5.0", # morefs incompatibly | ||
| "rapidfuzz", | ||
| "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 | ||
| "requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977 |
Contributor
There was a problem hiding this comment.
do we need it here at all with the pin in place in dagster-docker?
Contributor
Author
There was a problem hiding this comment.
[tests] installs docker directly
requests had a second patch release yesterday where the issue still persists.
gibsondan
reviewed
May 21, 2024
gibsondan
left a comment
gibsondan
left a comment
There was a problem hiding this comment.
not clear to me this needs to be anywhere other than dagster-docker given the stack trace? and maybe dagster[test]?
Contributor
Author
|
We're just going to revert once docker publishes to pypi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both docker-py and requests have fixes in flight. We can narrow our pin to only exclude the breaking version.
docker/docker-py#3257
psf/requests#6707 (comment)