Reduce exact rank assertions in ordering tests#4237
Open
marcus-pousette wants to merge 3 commits into
Open
Conversation
marcus-pousette
force-pushed
the
issue-4236-rank-order-tests
branch
from
a33174a to
026dfbd
Compare
raineorshine
reviewed
May 7, 2026
Contributor
|
Hi, thanks for creating this. A few initial comments above. |
Author
|
@raineorshine Thanks for the review. See my latest commit a751028. I hope this aligns with what you had in mind. |
Contributor
raineorshine
left a comment
raineorshine
left a comment
There was a problem hiding this comment.
Thanks! This looks better. The existing expectPathToEqual is a good idea for cursor assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4236.
This is a test-only pass that makes higher-level ordering tests assert ordered thought values instead of exact numeric
rankvalues where the rank number is not the behavior under test.Changes:
expectThoughtValuesfor readable ordered thought assertions.rankexpectations in cursor/path/order behavior tests.