Skip to content

Migrate snippets follow up#2789

Merged
phillco merged 6 commits into
mainfrom
migrateSnippetsV2
Jan 30, 2025
Merged

Migrate snippets follow up#2789
phillco merged 6 commits into
mainfrom
migrateSnippetsV2

Conversation

@AndreasArvidsson

@AndreasArvidsson AndreasArvidsson commented Jan 29, 2025

Copy link
Copy Markdown
Member
  1. Skip snippets with fields we cannot migrate instead of just discarding those fields
  2. Show a untitled markdown document with the migration results
  3. Use spoken forms/phrases from Talon

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

Comment thread packages/cursorless-vscode/src/migrateSnippets.ts Outdated
Comment thread packages/cursorless-vscode/src/migrateSnippets.ts Outdated
Comment thread packages/cursorless-vscode/src/migrateSnippets.ts Outdated
Comment thread packages/cursorless-vscode/src/migrateSnippets.ts
Comment thread packages/cursorless-vscode/src/migrateSnippets.ts Outdated
Comment thread packages/cursorless-vscode/src/migrateSnippets.ts
@phillco phillco enabled auto-merge January 30, 2025 16:52
@phillco phillco added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 2c19566 Jan 30, 2025
@phillco phillco deleted the migrateSnippetsV2 branch January 30, 2025 17:57
cursorless-bot pushed a commit that referenced this pull request Jan 30, 2025
1. Skip snippets with fields we cannot migrate instead of just
discarding those fields
2. Show a untitled markdown document with the migration results
3. Use spoken forms/phrases from Talon

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: Phil Cohen <phillip@phillip.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants