Skip to content

test(pstack): wait for the reap in the statechart SIGKILL view test #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poteto merged 1 commit into from
Oct 27, 2026
Merged

test(pstack): wait for the reap in the statechart SIGKILL view test #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions harness/pstack/claude-code/skills/statechart/scripts/test/cli.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 11 additions & 3 deletions pstack/skills/statechart/scripts/test/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,21 @@ async function signalWhile<T extends { dir: string; reached: (parent: string) =>

async function assertGone(pid: number) {
for (let i = 0; ; i++) {
let code: string | undefined;
try {
process.kill(pid, 0);
} catch (error) {
assert.equal((error as NodeJS.ErrnoException).code, "ESRCH");
return;
code = (error as NodeJS.ErrnoException).code;
// macOS gives EPERM for a process group of only zombies, until they are reaped.
if (code !== "EPERM") {
assert.equal(code, "ESRCH");
return;
}
}
assert.ok(i < 250, `Process ${pid} is still running.`);
assert.ok(
i < 250,
`Process ${pid} ${code ? "exited, but it was not reaped" : "is still running"}.`,
);
await sleep(20);
}
}
Expand Down
Loading