pstack: name maintain source readers and stop routing the pass through swarm - #264
Open
0xrep wants to merge 3 commits into
Open
pstack: name maintain source readers and stop routing the pass through swarm#2640xrep wants to merge 3 commits into
0xrep wants to merge 3 commits into
Conversation
…h swarm Give the source wave a bindable role, default inherit-parent, and readonly spawns. Map verified-unreachable onto clean/blocked. Drive the feature map text, not child recipes. Drop the guide line that sent the same job to /swarm.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 629f9d8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The source wave had no role name, so
pstack-models.mdccould not bind it and operators treated the pass as a/swarm. That composition hits the cloud async cap and drops readers.This names the role
maintain source readers, defaults it toinherit-parent, and spawns withreadonly: true. The coordinator still owns every live drive and executes the map's own Driving section, not child-derived recipes.verified-unreachableis acleancoverage result when the prerequisite and route are named. A product gap stays in the report and does not flip the pass tochangedorblocked.The guide no longer says a
/swarmcan split a full map pass. That line was how the wrong composition got taught.Skipped: fan-out caps, shared-harness re-drive, churn window, retry-once unit. Those remain operator notes.
Note
Low Risk
Documentation and agent-skill instructions only; no product code, auth, or runtime behavior changes.
Overview
Introduces a dedicated
maintain source readersrole for/maintain-verification-skill’s parallel source wave so/setup-pstackcan bind it inpstack-models.mdc(defaultinherit-parent). The maintain skill now spells out spawning those children as read-onlygeneralPurposetasks and explicitly says not to wrap the pass in/swarm—readers are not swarm workers; the coordinator still runs every live drive from the map’s Driving it with harness text, with child recipes only for drift reconciliation.Outcomes are tightened:
cleancounts source coverage plus live drive or documentedverified-unreachable; product gaps in the report alone don’t forcechanged/blocked.blockedapplies when a feature never got a source-wave return or wasn’t driven/classified. Target selection when multiple verify skills exist prefers the path in the current diff instead of guessing.The verify-and-ship guide drops the line that taught splitting a full map pass via
/swarmand mirrors the new maintain behavior and anti-swarm guidance.Reviewed by Cursor Bugbot for commit 916db3b. Bugbot is set up for automated code reviews on this repo. Configure here.