Skip to content

Strip Java case insensitive flags#108

Merged
aslakhellesoy merged 3 commits into
mainfrom
strip-java-case-insensitive-flags
Oct 10, 2022
Merged

Strip Java case insensitive flags#108
aslakhellesoy merged 3 commits into
mainfrom
strip-java-case-insensitive-flags

Conversation

@aslakhellesoy

@aslakhellesoy aslakhellesoy commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

🤔 What's changed?

Java parameter types using (?i) are now supported, with the caveat that the resulting JavaScript RegExp is not case insensitive. We simply remove any (?i) flags.

⚡️ What's your motivation?

Fix #100

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@aslakhellesoy aslakhellesoy merged commit fc77e03 into main Oct 10, 2022
@aslakhellesoy aslakhellesoy deleted the strip-java-case-insensitive-flags branch October 10, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Got an error when equesting textDocument/codeAction

1 participant