Glob paths not matching c-sharp files#89
Merged
mpkorstanje merged 1 commit intoDec 20, 2023
Conversation
1f09500 to
7387e3f
Compare
Member
Author
|
Issue was previously resolved within the VSCode extension (cucumber/vscode#93). However, as it was never updated in the Language Server first, when the list of glob patterns was extended for new languages within this repository, they were also applied back into the VSCode repo (following documented procedure) and included the previous patterns for C# - inadvertently reverting the fix. Once this fix is merged, will update the changes within the VSCode extension. |
mpkorstanje
approved these changes
Dec 20, 2023
kieran-ryan
added a commit
to kieran-ryan/vscode
that referenced
this pull request
Dec 21, 2023
See Language Server PR: cucumber/language-server#89
5 tasks
kieran-ryan
added a commit
to cucumber/vscode
that referenced
this pull request
Dec 21, 2023
* Fix glue for csharp steps * Fix changelog file * Align C# config with language server See Language Server PR: cucumber/language-server#89 --------- Co-authored-by: Kieran Ryan <kierankilkenny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default glob paths for c-sharp step definition and feature files match the names that contain only the file extension (no stem) - e.g. complete filenames called
.csand.feature- thus must be configured by the user in all cases at present.🤔 What's changed?
⚡️ What's your motivation?
🏷️ What kind of change is this?
📋 Checklist: