Skip to content

Specify minimum compatible node version#100

Merged
kieran-ryan merged 4 commits into
mainfrom
drop-node-14
Mar 23, 2024
Merged

Specify minimum compatible node version#100
kieran-ryan merged 4 commits into
mainfrom
drop-node-14

Conversation

@kieran-ryan

@kieran-ryan kieran-ryan commented Mar 23, 2024

Copy link
Copy Markdown
Member

🤔 What's changed?

  • Dropped support for node v14
  • Simplified job matrix to run all node versions against MacOS, Ubuntu and Windows
  • Specified minimum compatible node engine (version)

⚡️ What's your motivation?

  • Fixes CI: is it time to let go of Node 14? #97 - which causes workflow failures due to node v14 incompatibility
  • Released server already has incompatibilities with node v14 due to tree-sitter issues
  • node v14 was not being run against Windows in the workflow

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

@kieran-ryan kieran-ryan changed the title Drop node v14 support Specify minimum compatible node version Mar 23, 2024
@kieran-ryan kieran-ryan added the 🏦 debt Tech debt label Mar 23, 2024
@kieran-ryan kieran-ryan self-assigned this Mar 23, 2024
@kieran-ryan kieran-ryan merged commit 578e469 into main Mar 23, 2024
@kieran-ryan kieran-ryan deleted the drop-node-14 branch March 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏦 debt Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: is it time to let go of Node 14?

1 participant