esm: rename bin script file to avoid loader issues#1993
Merged
davidjgoss merged 6 commits intomainfrom Apr 12, 2022
Merged
Conversation
This was referenced Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR renames the file in
binfromcucumber-jstocucumber.js, and changes the documentation for ESM to say that we can support loaders.⚡️ What's your motivation?
This is to avoid issues when using some ESM loaders, where Node.js doesn't understand what to do with the extensionless file. Fixes #1844 (which also gives details of the issues being encountered), and tested against the minimal example repo there which confirmed the fix.
Note that this isn't a breaking change - users will continue to run
cucumber-jsbecause npm symlinks that command to whatever file is specified in thebinsection of thepackage.json. Nonetheless, we'll put it in a minor release just to be a little defensive. Mocha has done the same thing for the same reasons in mochajs/mocha#4863.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.