Skip to content

[Notification Hub] UI changes to add screen + components (pulled from #16)#87

Merged
Mihilih merged 3 commits intomainfrom
mihilih/notifs
Nov 19, 2025
Merged

[Notification Hub] UI changes to add screen + components (pulled from #16)#87
Mihilih merged 3 commits intomainfrom
mihilih/notifs

Conversation

@Mihilih
Copy link
Contributor

@Mihilih Mihilih commented Nov 19, 2025

Overview

Added the changes UI changed related to notifications hub from #16 and updated the viewmodel and data classes as needed

Changes Made

  • notifications/NotificationCard.kt : element for a notification and the element for a swipable notification card
  • notifications/ResellNotificationScroll.kt : Element for all the notifications on the notifications hub screen
  • NotificationsHubScreen.kt : Notifications hub screen with all notifications
  • Added navigation from HomeScreen to NotificationsHubScreen
  • Added relevant data class InAppNotif

Test Coverage

Samsung A36 Physical Emulator

Next Steps

Add networking to populate the notif hub with data

Related PRs or Issues

Changed derives from #16

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the notification hub UI components and screens to the Resell Android app. The changes establish the foundation for displaying in-app notifications with filtering, categorization, and swipe-to-archive functionality, though the networking implementation is deferred to future work.

Key Changes:

  • New notification hub screen with time-based categorization (New, Last 7 Days, Last 30 Days, Older)
  • Swipeable notification cards supporting archive gestures
  • Filter system for notification types (MESSAGE, REQUEST, DISCOUNT, etc.)

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
ic_unread_message.xml New vector drawable icon for unread message indicator
ic_notification_bell.xml New vector drawable icon for notification bell
InAppNotifViewModel.kt ViewModel managing notification state, categorization logic, and user interactions
HomeViewModel.kt Added navigation handler to notifications hub screen
Functions.kt Added isoToTimeAgo() utility for time-relative display formatting
Color.kt Added ResellPurpleWash color for unread notification backgrounds
RootNavigation.kt Added navigation route for notifications hub screen
NotificationsScreen.kt Main notification hub screen with header, filters, and scrollable content
HomeScreen.kt Integrated notification button navigation from home screen
ResellNotificationsScroll.kt Scrollable component rendering categorized notification lists
NotificationCard.kt Notification display components with swipe-to-archive functionality
InAppNotif.kt Data classes for in-app notification structure and additional metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zachseidner1
Copy link
Collaborator

Are there any differences from #16 in this PR? If not we could probably just merge it right in

@Mihilih
Copy link
Contributor Author

Mihilih commented Nov 19, 2025

Are there any differences from #16 in this PR? If not we could probably just merge it right in

Only major difference is that I changed the data class to match what's being sent from the backend. Other that that there were a few tweaks I had to make but nothing major

Copy link
Collaborator

@zachseidner1 zachseidner1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just approved since this has mainly already been reviewed and will probably be fine. One thing that I think is important though is the naming of using Notif instead of Notification. Notification doesn't take much longer to write out and I think it significantly improves readability, so I would appreciate if we can get rid of "Notif".

@Mihilih Mihilih merged commit 1c848c8 into main Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants