Repository navigation
feat: add collection and catch log parity to iOS app - #58
Merged
Merged
Conversation
- Add Pokédex and Catch Log segmented navigation to iOS CollectionView - Support Unown 28 letter forms viewing and interactive selection in Pokédex grid and details - Add comprehensive read-only PokemonDetailView to iOS: animated sprite, individual picker, computed stats with IVs, known moves, species base stats, types, height/weight, BST, abilities, and complete move list - Extend PhonePayload with backward-compatible catchLog, unownForms, and species details - Preload and serialize species details and catch log entries from Mac app - Support unown form sprite resolution in SpriteCache and PokeSprite - Add unit tests for payload codable backward compatibility, catch log, and phone dex conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the iOS companion app's Collection tab to feature parity with the macOS version while keeping all views and actions completely read-only.
Key highlights:
★), shiny badge (✨), raising badge, and Unown letter form count (X/28).RAISING/RELEASED/✨status badges, nature name, and multi-stage evolution chain sprites.#1 · Lv. X,#2 · Lv. Y) for multi-catch species or log entries.m), weight (kg), Base Stat Total (BST), base stats, possible abilities (regular and hidden), and complete move pool with learn methods.PhonePayloadandPhoneDexSpeciesextended withcatchLog,unownForms, anddetails.SpriteCacheandPokeSpritesupport PokéAPI Unown form sprite resolution (201-{form}.png).Type of change
UI changes
Checklist
swift buildandswift testpass locally