Skip to content

[False-Positive]: assembly function parameters that are mixed case get flagged as not mixed case #1815

@thedavidmeister

Description

@thedavidmeister

Describe the false alarm that Slither raise and how you know it's inaccurate:

Here's a test run where you can see it https://github.com/rainprotocol/sol.lib.memory/actions/runs/4573416969/jobs/8073830167#step:6:373

Parameter LibUint256Array.unsafeExtend.asm_0.extendInline().base__unsafeExtend_asm_0_extendInline (src/LibUint256Array.sol#236) is not in mixedCase
Parameter LibUint256Array.unsafeExtend.asm_0.extendInline().extend__unsafeExtend_asm_0_extendInline (src/LibUint256Array.sol#236) is not in mixedCase

I think it's just the way that assembly is doing things internally to rename function params, and i guess slithers sees the renamed param not the original param

Frequency

Rarely

Code example to reproduce the issue:

        assembly ("memory-safe") {
            function extendInline(base_, extend_) -> baseAfter_ {

https://github.com/rainprotocol/sol.lib.memory/blob/main/src/LibUint256Array.sol#L235

Version:

0.9.3

Relevant log output:

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions