Bump rustc version#690
Merged
Merged
Conversation
My reasoning is as follows: we need an up-to-date rust-overlay in order to access recent nightlies. Currently we follow crane's rust-overlay, but recent versions of crane don't have a rust-overlay input anymore. So we'll need to have rust-overlay as input like this eventually anyway. Hence I did this without even updating crane because there was no need.
W95Psp
approved these changes
May 28, 2024
W95Psp
left a comment
W95Psp
left a comment
Contributor
There was a problem hiding this comment.
That's great, looks good to me!
The nix change makes sense indeed :)
Collaborator
Author
|
Charon is ready |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This is not breaking anything on hax, but unbreaks `serde`: serde-rs/serde#2734
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the record, some of the changes that caused conflicts:
constnessfromParamEnvrust-lang/rust#114134I'm leaving it in draft while I fix charon