Skip to content

Inject FullVersionChecker with new DI framework #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobihagemann merged 2 commits into from
Oct 16, 2023
Merged

Inject FullVersionChecker with new DI framework #323

tobihagemann merged 2 commits into from
Oct 16, 2023

Conversation

@phil1995
Copy link
Collaborator

@phil1995 phil1995 commented Oct 15, 2023

Updates CryptomatorSettings and the FullVersionChecker to use the recently introduced dependency injection framework.

Please test:

  • existing full version via IAP gets still correctly recognized (Main App & FileProvider)
  • debug mode can be enabled / disabled and internally works
  • the always premium version works as expected

@phil1995 phil1995 requested a review from tobihagemann October 15, 2023 13:16
tobihagemann
tobihagemann requested changes Oct 16, 2023
View reviewed changes
@phil1995 phil1995 requested a review from tobihagemann October 16, 2023 15:52
@tobihagemann tobihagemann merged commit 447831a into develop Oct 16, 2023
@tobihagemann tobihagemann deleted the feature/dependency_injection-fullversionchecker branch October 16, 2023 21:08
@tobihagemann tobihagemann added this to the 2.5.0 milestone Oct 16, 2023
@phil1995 phil1995 mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobihagemann tobihagemann tobihagemann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@phil1995 @tobihagemann