Conversation
kmindi
requested changes
Apr 21, 2018
Collaborator
kmindi
left a comment
There was a problem hiding this comment.
Nice, I have only a few remarks:
- Move everything below the example, so the example stays the first thing to bee seen.
- Don't use h2, but a less big heading.
- I'd expect the source code under the heading "sources" not the references
- I'd expect "Version History" instead of "changes to this example"
- I'd expect reviews to be a separate heading.
Contributor
Author
|
@kmindi As discussed. The jekyll-last-modified-at plugin is not available on github page (github/pages-gem#119) So, one have to enter the date oneself. However, I copy this value to Note, the spelling mistake in the screenshot was fixed (Reviewes). If you like to have other names for the headings, feel free to change them on this branch. |
kmindi
requested changes
Apr 24, 2018
| {% assign site.last_updated = page.last_updated %} | ||
| {% if page.references %} | ||
| <ul> | ||
| <h3>References</h3> |
_layouts/page.html
Outdated
| {% endif %} | ||
|
|
||
| {% if page.current_reviews %} | ||
| <h3>Last Reviews</h3> |
Collaborator
There was a problem hiding this comment.
Reviews (not Last Reviews)
kmindi
approved these changes
Apr 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The html is not perfect. But IMO for the Prozessanalyse sufficient.
The syntax includes everything which was required/discussed on 27th March (sources, author name, author url, reviewers' names/company/..., link to reviewers' webpage, reviewed commits). Security Features can be realized by using tags.
Syntax for md files, here as part of
java_easy_AES_string_encryption.md:Yields this page: