Adds ElasticModel::Instrumentation - #1
Open
quentindecock wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
you should be assuming a YAML file present in the config directory for this instead. Make it such that if you cant read that file, it throws an exception saying that the file is needed
Contributor
Author
There was a problem hiding this comment.
Bug that should be in the config file of the Rails project.
How can I test it in isolation then?
Contributor
Author
There was a problem hiding this comment.
I have it marked as TODO I will implemented this is a future pull request.
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.