Update Crossplane dependencies to get the new APIs module#293
Update Crossplane dependencies to get the new APIs module#293adamwg merged 2 commits intocrossplane:mainfrom
Conversation
The core Crossplane resource APIs have moved from crossplane-runtime to the new crossplane/apis module. Update our references to use the new paths. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 54 minutes and 38 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request migrates Crossplane API type usage from v1 common types to v2 core types across composed and composite resource implementations, updating method signatures and internal status handling while preserving existing control flow. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| package composed | ||
|
|
||
| import ( | ||
| xpv2 "github.com/crossplane/crossplane/apis/v2/core/v2" |
There was a problem hiding this comment.
compared to xpv1 "github.com/crossplane/crossplane-runtime/v2/apis/common/v1" is this the same ? or we stop supporting v1 ?
There was a problem hiding this comment.
Good question. Before the move, common/v1 and common/v2 were the same except for namespaced resource support - callers needed to use v1 types for cluster-scoped and v2 types for namespace-scoped. Since v2 actually supports both, we've combined them into core/v2 (naming the duplicate types to indicate cluster-scoped vs. namespaced) and removed the v1 package.
There was a problem hiding this comment.
Means we need to document this behaviour Change with the next release
There was a problem hiding this comment.
I don't think there are any behavioral changes for function-sdk-go, but we definitely need to document the change in package organization for the next crossplane and crossplane-runtime release.
Description of your changes
The core Crossplane resource APIs have moved from crossplane-runtime to the new crossplane/apis module. Update our references to use the new paths.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Existing unit tests.