This repository was archived by the owner on Nov 20, 2021. It is now read-only.
Add arg for adding custom labels to kube-proxy pods#31
Merged
Conversation
|
|
clambert796
force-pushed
the
kube-proxy-labels
branch
2 times, most recently
from
12fc782 to
834dfdd
Compare
remove dev.yaml update v1alpha1 remove print statements add extra arg to kube-proxy v1alpha1 almost works maybe clean up code update templates remove dev.yaml update v1alpha1
ChrisRx
force-pushed
the
kube-proxy-labels
branch
from
834dfdd to
ec4a2d3
Compare
ChrisRx
approved these changes
Jan 4, 2021
Member
ChrisRx
left a comment
ChrisRx
left a comment
There was a problem hiding this comment.
@clambert796 I rebased the branch to get it up-to-date after merging the other PR, but this lgtm so can go ahead and merge, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to set custom labels in their kubeproxy configuration.
Testing:
Created a local cinder cluster with the updated crit binary. Specified a config with an extra label and verified it appeared on the pod.
Our use case only requires labels on the pods, but I can add the labels to the daemonset as well if you'd like to see that supported.