PROV definitions as OAP Part 5 - #994
Open
fmigneault wants to merge 12 commits into
Open
Conversation
…tests for job definition endpoint
…, alternate links, and OGC API Part 5 URI errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes:
GET /jobs/{jobId}/definition(replacesGET /jobs/{jobId}/inputs) with themost recent
OGC API - Processes - Part 4: Job Managementspecification,which includes the
entityURI of the appropriateProcessdefinition at the root of theJob/Workflow.application/provenance+jsonandapplication/provenance+xmlfor corresponding provenance media-types(fixes Support
application/provenance+xmlfor PROV-XML #987)./conformancereferences ofJobdefinition and provenance requirements and recommendations.Jobprovenance error responses with standardtypeURIs.Fixes:
Jobprovenance to provideWeaverandweaver-workerreferences asSoftwareAgentrather thanPerson(relates to PROV: improve source code references #965).
Joblinks when they include a result with a?f={mediaType}query parameter.The URL pattern did not correctly provide the anchor and query parameter components. Also, if the media-type had some
special characters (e.g., a space between its parameters), it would fail due to the missing URL encoding. Finally, the
actual URL returned was missing the
/results/portion of the/jobs/{jobId}/results/{outputId}endpoint.unquoteoperation to handle URL encoding for?f={mediaType}on result endpoint for above change.