Consolidate checks for completion file exists#273
Merged
TimidRobot merged 4 commits intocreativecommons:mainfrom Jan 28, 2026
Merged
Consolidate checks for completion file exists#273TimidRobot merged 4 commits intocreativecommons:mainfrom
TimidRobot merged 4 commits intocreativecommons:mainfrom
Conversation
TimidRobot
requested changes
Jan 23, 2026
Member
TimidRobot
left a comment
There was a problem hiding this comment.
please update to better support --quarter in the report scripts
9 tasks
This comment was marked as outdated.
This comment was marked as outdated.
TimidRobot
requested changes
Jan 28, 2026
Member
TimidRobot
left a comment
There was a problem hiding this comment.
Please update all three report scripts per the comments below.
Please remember to test your changes. For example:
pipenv run ./scripts/3-report/gcs_report.py --quarter 2025Q3Had you done so, you would have seen the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Description
I merged the functions that checks for processed files in process script and the last entry in report script. The function
check_completion_file_exists()now performs both task in shared.py.Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin