Skip to content

Fix grpc build#1055

Open
crazywhalecc wants to merge 1 commit intomainfrom
fix/grpc-build
Open

Fix grpc build#1055
crazywhalecc wants to merge 1 commit intomainfrom
fix/grpc-build

Conversation

@crazywhalecc
Copy link
Owner

What does this PR do?

Closes #1054

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Mar 9, 2026

Using ext-grpc to compile all grpc dependencies looks not good for our build procedure.

First of all, it's too slow for building static php binary every time. Building separately could reduce a lot of time when debugging and publishing. And another potential issue is building openssl, libcares and zlib twice. And also, although we can make a patch for boringssl and openssl built by grpc source to solve the CI error above, it often leads to misleading errors when building in-tree ext-grpc with all dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ext-grpc build failed on macOS and Linux

1 participant