Fix #14744: Invalid AST for braced init and references/pointers#8549
Open
ludviggunne wants to merge 3 commits intocppcheck-opensource:mainfrom
Open
Fix #14744: Invalid AST for braced init and references/pointers#8549ludviggunne wants to merge 3 commits intocppcheck-opensource:mainfrom
ludviggunne wants to merge 3 commits intocppcheck-opensource:mainfrom
Conversation
| } | ||
|
|
||
| void astbracedinit() { | ||
| ASSERT_EQUALS("intab{&", testAst("int &a { b };")); |
Collaborator
There was a problem hiding this comment.
The tests seem to reflect the status quo, i.e. the AST still contains &, &&, and *.
Collaborator
Author
There was a problem hiding this comment.
Hm weird... it looks good with --debug --verbose so I just copy-pasted from these. Are there parts of the AST that are not printed with those flags?
Collaborator
There was a problem hiding this comment.
The test code is not tokenized like regular code, especially varids are not set. Maybe ListSimplification::Full would help.
Collaborator
Author
There was a problem hiding this comment.
Ok, there is a cyclic AST exception with ListSimplification::Full, so this needs additional work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.