Conversation
Some older python versions (e.g. 3.5.2) don't have it.
fzipi
approved these changes
Nov 20, 2020
Member
fzipi
left a comment
fzipi
left a comment
There was a problem hiding this comment.
I mean, technically LGTM.
But... 2020.... do we need to support SSLv3? Don't get me wrong, I like to be inclusive.
I think you have additional tests not present here, right?
Contributor
Author
PROTOCOL_SSLv23 is an alias for PROTOCOL_TLS in newer systems (> 2.7.12 and > 3.5.2). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And bump in preparation for a new release.