Skip to content
This repository was archived by the owner on Feb 5, 2020. It is now read-only.

Remove platforms - azure/gcp/govcloud/vmware/openstack - #3134

Merged
squat merged 16 commits into
coreos:masterfrom
cpanato:remove_platforms
Mar 26, 2018
Merged

Remove platforms - azure/gcp/govcloud/vmware/openstack#3134
squat merged 16 commits into
coreos:masterfrom
cpanato:remove_platforms

Conversation

@cpanato

@cpanato cpanato commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

Cleaning master by removing azure, govcloud, metal, gcp, openstack and vmware.

Those platforms will be readded, when we advance in the new installer flow. For now we are focus on AWS.

@squat squat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to modify the rules in examples/BUILD.bazel and Documentation/BUILD.bazel

@cpanato

cpanato commented Mar 23, 2018

Copy link
Copy Markdown
Contributor Author

@squat it uses the variables.bzl I changed that only. let me know if this is not good

@enxebre

enxebre commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

as we are not supporting track-1 in this branch anymore we can remove bootkube module, rename bootkube-ut2 to bootkube and update the references in the steps folder now.

@enxebre

enxebre commented Mar 23, 2018

Copy link
Copy Markdown
Contributor
  • can we also remove modules/openstack?
  • Also I'd be in favour of removing non platform specific but unused modules e.g modules/bootstrap-ssh, dns/azure, dns/gcp wdyt?
  • In the root BUILD.bazel there's glob pointing to "platforms" folder that should be removed now
  • Can we also remove the root Makefile?
  • Also modules/ignition can be cleanup now, but let's do that in a different PR

@squat
squat merged commit 7214caa into coreos:master Mar 26, 2018
@sym3tri

sym3tri commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

@squat I agree with @enxebre

@cpanato
cpanato deleted the remove_platforms branch March 26, 2018 11:51
@squat squat mentioned this pull request Mar 26, 2018
@bluecmd

bluecmd commented Mar 31, 2018

Copy link
Copy Markdown

FYI, this broke a link on https://coreos.com/tectonic/docs/latest/install/vmware/vmware-terraform.html

Edit the parameters with details of the VMware infrastructure. View all of the VMware specific options and the common Tectonic variables.

wking added a commit to wking/openshift-installer that referenced this pull request Mar 28, 2019
The final consumer was removed in 361c082 (govcloud: remove
terraform configs, 2018-03-23, coreos/tectonic-installer#3134).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants