This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Add more detail on agent#70
Merged
Merged
Conversation
|
Can one of the admins verify this patch? |
euank
suggested changes
Apr 27, 2017
euank
left a comment
euank
left a comment
Contributor
There was a problem hiding this comment.
Looks good other than the one comment.
Thanks!
| ## Usage | ||
|
|
||
| To start `update-operator` and `update-agent`: | ||
| To start the `update-operator` DaemonSet, run: |
euank
reviewed
Apr 27, 2017
| ``` | ||
| # Open examples/components.yaml and edit the image tag. | ||
| kubectl create -f examples/components.yaml | ||
| kubectl create -f examples/update-operator.yaml |
Contributor
There was a problem hiding this comment.
Oh, also, should the comment still be there?
Right now it still has "${TAG}", though I'd be in favour of updating TAG to be the latest release instead as an alternate solution.
Contributor
Author
There was a problem hiding this comment.
Yeah, I like the idea of using latest by default since I assume that's what 99% of users will want.
jamiehannaford
force-pushed
the
update-readme
branch
from
1b188fc to
5aad797
Compare
Contributor
Author
|
Thanks for reviewing @euank. I've made the suggested changes. |
Contributor
|
Guess we should start pushing a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current README references a non-existent file in
examples, so I've pointed to the right file. I've also added clarification on how the agent runs and other minor things 😃