This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Release v0.6.0#169
Merged
Merged
Conversation
Contributor
|
I don't feel strongly either way but does this warrant a full minor version release? especially so soon after the previous one. if you have a particular reason for it though, it seems fine to me. |
Contributor
Author
|
Yeah, I'm not so thrilled to have such a tiny release either. Its slightly more of a feature than a fix was my logic, but I could see either way. |
Contributor
|
I guess since it does things like break the kvo when it tries to mess with our annotations, a minor version is probably warranted. let's just leave it as is. |
sdemos
approved these changes
Jan 25, 2018
Contributor
Author
|
Yeah. And we'd wait for more features, but Tectonic seems to need this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes:
container-linux-update.v1.coreos.com/reboot-needed: "true"label to reflect the "reboot-needed" annotation ( agent: set a label when after successful os-update #168)