This repository was archived by the owner on Sep 18, 2020. It is now read-only.
agent: deserialize waitForPodDeletion check.#150
Merged
Conversation
Contributor
|
Let's have the WaitGroups be separate and write the UID check to mirror upstream drain (and handle nil) #151. |
Contributor
Author
|
Ok, do you want me to scope this PR just to the waitgroup fix then? |
Contributor
|
Sure |
diegs
changed the title
dghubble
approved these changes
Oct 24, 2017
dghubble
left a comment
dghubble
left a comment
Contributor
There was a problem hiding this comment.
Rebase if you haven't already. LGTM
This adds a sync.WaitGroup to check all pods concurrently and avoid erroneously extended grace periods.
Contributor
Author
|
Rebased, though strictly not necessary since no conflicts... cc @euank :) |
Contributor
|
Our repo allows merge commits. Was it indicating otherwise @dghubble? |
Contributor
|
Habit, looks like its not enforced, which I'm fine with |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a sync.WaitGroup to check all pods concurrently and avoid
erroneously extended grace periods.