This repository was archived by the owner on Sep 18, 2020. It is now read-only.
pkg/updateengine: Return the right error on Call failures#148
Merged
Conversation
sdemos
approved these changes
Oct 24, 2017
sdemos
left a comment
sdemos
left a comment
Contributor
There was a problem hiding this comment.
lgtm. +1 on removing the named returns.
Contributor
|
actually, is there any reason why you didn't also remove the named returns on the |
Contributor
Author
|
Yeah, we could drop the named returns. |
sdemos
approved these changes
Oct 24, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On call errors, the
errfrom theHellowas returned instead of thecall.Errreason for the call failure.