Skip to content
This repository was archived by the owner on Sep 18, 2020. It is now read-only.

Update kubernetes packages#140

Merged
dghubble merged 5 commits into
masterfrom
update-kubernetes-packages
Oct 16, 2017
Merged

Update kubernetes packages#140
dghubble merged 5 commits into
masterfrom
update-kubernetes-packages

Conversation

@dghubble

@dghubble dghubble commented Oct 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Update kubernetes, client-go, and apimachinery to versions used in KVO
  • Switch to using client-go ConfigMap leader election instead of endpoints
  • Requires client-go newer than v0.4.0 (latest tagged release) for leader election changes.
    • Downside to this is that its hard to say exactly how many Kubernetes versions in the future this is compatible with. On the other hand, getting all the kubernetes packages to match up properly is so chaotic, I'm not convinced "official" releases are that much more of a guarantee

Reasons:

  • client-go v3.0.0-beta is quite old. We should update asap now that Kubernetes 1.8 is out.

@dghubble

dghubble commented Oct 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Test image: quay.io/dghubble/container-linux-update-operator:c38884b70061ee98ed2b5ab15e0c9da213c027ce-dirty (dirty bc the build scripts assume sudoless docker).

@squeed

squeed commented Oct 9, 2017

Copy link
Copy Markdown

For my own knowledge, why do you need a pre-release version of client-go? I thought ConfigMap elections were in k8s 1.7!?!?

@dghubble

dghubble commented Oct 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Leader election hadn't been moved to client-go yet in v0.4.0. Its slated for v0.5.0.

If you compare with KVO (internal), this glide.yaml should match what's used there to perform election in other operators.

@dghubble dghubble requested review from sdemos and yifan-gu October 9, 2017 17:47
@dghubble dghubble mentioned this pull request Oct 9, 2017
Merged
@squeed

squeed commented Oct 10, 2017

Copy link
Copy Markdown

Cool, thanks for the info.

@dghubble
glide.yaml: Update from client-go v3.0.0-beta.0 to v3.0.0
9f501bb
@dghubble
vendor: Vendor client-go v3.0.0
79a4237
@dghubble
pkg,glide: Sync Kubernetes dependencies with KVO
b7d4151 
* Switch to using client-go ConfigMap leader election
* Requires client-go newer than v0.4.0. Sync dependencies
with those used by KVO
@dghubble
vendor: Revendor kubernetes, client-go, and apimachinery
12c23aa
@dghubble
travis.yml: Test Go 1.9 and remove Go 1.7 testing
d298670 
* Kubernetes packages require 1.8
* Bump the build image from Go 1.8.3 to 1.8.4
@dghubble dghubble force-pushed the update-kubernetes-packages branch from c38884b to d298670 Compare October 10, 2017 20:13
@dghubble dghubble merged commit 824c4ce into master Oct 16, 2017
@dghubble dghubble deleted the update-kubernetes-packages branch October 16, 2017 20:00
@dghubble dghubble mentioned this pull request Oct 16, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yifan-gu yifan-gu Awaiting requested review from yifan-gu
1 more reviewer
@sdemos sdemos sdemos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dghubble @squeed @sdemos