Skip to content

test: add layout for raid1 test#1087

Merged
cgwalters merged 1 commit into
coreos:mainfrom
HuijingHei:fix-raid-test
Apr 27, 2026
Merged

test: add layout for raid1 test#1087
cgwalters merged 1 commit into
coreos:mainfrom
HuijingHei:fix-raid-test

Conversation

@HuijingHei

Copy link
Copy Markdown
Contributor

@openshift-ci

openshift-ci Bot commented Apr 20, 2026

Copy link
Copy Markdown

Hi @HuijingHei. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the RAID1 test configuration in tests/kola/raid1/config.bu to include a layout field with a {{LAYOUT}} placeholder. The review feedback correctly identifies that the placeholder should be enclosed in double quotes to prevent YAML parsing errors, as values starting with curly braces are interpreted as flow mappings.

Comment on lines +4 to +5
# The {{LAYOUT}} will be replaced by https://github.com/coreos/coreos-assembler/pull/4525
layout: {{LAYOUT}}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The placeholder {{LAYOUT}} should be enclosed in double quotes. In YAML, a value starting with { is interpreted as the start of a flow mapping. Quoting the placeholder ensures the file remains valid YAML and is correctly treated as a string by linters and editors. Additionally, consider making the comment more descriptive of the placeholder's purpose rather than just providing a link to a pull request.

  # The {{LAYOUT}} placeholder is replaced by the platform-specific layout (e.g. BIOS, EFI)
  layout: "{{LAYOUT}}"

@cgwalters cgwalters merged commit ab0d9a1 into coreos:main Apr 27, 2026
11 checks passed
@Johan-Liebert1 Johan-Liebert1 mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants