test: add layout for raid1 test#1087
Conversation
|
Hi @HuijingHei. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Code Review
This pull request updates the RAID1 test configuration in tests/kola/raid1/config.bu to include a layout field with a {{LAYOUT}} placeholder. The review feedback correctly identifies that the placeholder should be enclosed in double quotes to prevent YAML parsing errors, as values starting with curly braces are interpreted as flow mappings.
| # The {{LAYOUT}} will be replaced by https://github.com/coreos/coreos-assembler/pull/4525 | ||
| layout: {{LAYOUT}} |
There was a problem hiding this comment.
The placeholder {{LAYOUT}} should be enclosed in double quotes. In YAML, a value starting with { is interpreted as the start of a flow mapping. Quoting the placeholder ensures the file remains valid YAML and is correctly treated as a string by linters and editors. Additionally, consider making the comment more descriptive of the placeholder's purpose rather than just providing a link to a pull request.
# The {{LAYOUT}} placeholder is replaced by the platform-specific layout (e.g. BIOS, EFI)
layout: "{{LAYOUT}}"
See coreos/coreos-assembler#4525