Repository navigation
fix: negated classes match runes not bytes - #180
Merged
Merged
Conversation
Go 1.27.2 uses export data version 5, golangci-lint v2.13 supports only version 4. CI failed on v0.12.27 merge commit.
Remove 0x80-0xFF single-byte range from coversAllNonASCII path in NFA
compiler. This range caused negated classes (\S, \D, \W, [^x]) to match
individual bytes of valid multi-byte UTF-8 runes — e.g. \S{2} matched
single Cyrillic character К (2 bytes) by treating each byte as a
separate match.
Invalid UTF-8 byte handling deferred to #179 (look-ahead design).
Skipped TestInvalidUTF8NegatedCharClass until then.
Fixes #174
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Benchmark ComparisonComparing Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x80–0xFFsingle-byte range fromcoversAllNonASCIIpath in NFA compiler\S,\D,\W,[^x]) to match individual bytes of valid multi-byte UTF-8 runes — e.g.\S{2}matched single CyrillicК(2 bytes)Test plan
go test ./... -short)Fixes #174