Repository navigation
fix: remove BranchDispatch, fix ExtractFirstBytes FoldCase (#166) - #172
Merged
Merged
Conversation
BranchDispatch produced false negatives (^x(a|bc) on "xbc") and false positives (^(GET|POST) / on "GET x") by ignoring prefix/suffix around alternation and using "assume true" fallbacks for non-literal branches. Removed entirely: lazy DFA and BoundedBacktracker already provide correct O(1) first-byte dispatch inherently (as Rust regex does). Anchored alternations now route to UseBoundedBacktracker with O(1) first-byte reject. Performance: 13→66 ns short strings, still 1.5x faster than stdlib. ExtractFirstBytes: added SimpleFold orbit for FoldCase literals and UTF-8 lead-byte handling for non-ASCII runes. Fixes ^[Vv] rejecting "v". Closes #166
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Benchmark ComparisonComparing Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166. BranchDispatch removed (false negatives/positives on anchored alternations). ExtractFirstBytes: SimpleFold orbit + UTF-8 lead-bytes. See CHANGELOG for details.