Day/night backlight color - #1596
nick1udwig wants to merge 6 commits into
Conversation
Signed-off-by: Nick Ludwig <nick.b.ludwig@gmail.com> Co-Authored-By: GPT-5.5-xhigh
Signed-off-by: Nick Ludwig <nick.b.ludwig@gmail.com> Co-Authored-By: GPT-5.5-xhigh
Signed-off-by: Nick Ludwig <nick.b.ludwig@gmail.com> Co-Authored-By: GPT-5.5-xhigh
How to use it: cd path/to/PebbleOS ./pbl configure --board=qemu_emery ./pbl build ./pbl qemu --qemu-decoration none In another terminal: ./pbl console backlight daynight start backlight daynight status backlight daynight status backlight daynight off Signed-off-by: Nick Ludwig <nick.b.ludwig@gmail.com> Co-Authored-By: GPT-5.5-xhigh
|
This is really cool! CC: @ericmigi |
|
Nice! Do you want to try it for a bit and see how it feels? The risk is that readability drops a bit depending on colour, so it would be good to test out |
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
I like the idea. I think it should be controlled by a new mobile settings menu following eg iOS ('Night shift'), which can be scheduled. Could you post some screenshots of the whole solution? Thanks!
|
Thanks for the feedback! Will address review on the mobile side, then post some screencaps. |
|
This looks really cool. Is the idea that it does a hard switch between the designated rgb light color at sunrise/sunset or does it transition between them over a period of time like with flux or nightshift? |
Currently implemented as a hard switch at sunrise/sunset. In addressing this round of feedback I plan to make the "sunrise/sunset" times user-configurable, so the mobileapp will give options to:
|
|
Ok, here are some screencaps of the current UI. I did not make it a separate screen like night shift because I didn't see that anywhere else in the UI, but am happy to change it in whatever way is desireable. More discussion of changes on coredevices/mobileapp#265 (comment) 
|
|
one minor observation - perhaps, put simply "Use local sunrise/sunset" instead of mentioning the weather. It's not relevant to the user where this data comes from - just that it is for their current location. |
Good point, I'll change the text. However, it may be useful to indicate to users that this feature is gated by weather functionality being enabled: otherwise, if a user has weather off, this feature will be mysteriously grayed out and unavailable! Perhaps the text should render as "Use local sunrise/sunset" when weather is on; "Use local sunrise/sunset (Settings > Weather must be enabled)" when weather is off. |
Signed-off-by: Nick Ludwig <nick.b.ludwig@gmail.com> Co-Authored-By: GPT-5.5-xhigh
|
Tweaked wording here: coredevices/mobileapp@84c1dc1 |
Signed-off-by: Nick Ludwig <nick.b.ludwig@gmail.com> Co-Authored-By: GPT-5.5-xhigh
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
|
I missed the bot above closing this PR. Is there any interest in this PR from the team? If so, please reopen. Thanks! |
|
I’d also really like to see this PR revived. I’m using a Pebble Time 2 and this is a feature I would use every day. I’ve added some thoughts to #1139 about optionally making the sunrise/sunset change gradual, similar to f.lux / Night Shift, with the transition centered around sunset and sunrise. More importantly, I’d be happy to test this on actual Pebble Time 2 hardware, including readability with different day/night colors and pure red (#FF0000) at night, if that would help move the PR forward. It looks like a lot of the work is already here, so it would be a shame for it to remain closed only because the stale bot caught it. |
|
I’m really interested too! |
|
I'd be happy to continue shepherding this PR if the Core Devices team is interested in the contribution. |
7 participants
Problem
Would be nice if watches with RGB backlight could automatically switch backlight color, with one color for day and one for night.
Resolves #1139.
Solution
For watches that have RGB backlight, add
default_color_nightstate along with time tracking for sunset/sunrise.Notes
Tested with QEMU, but not on a live watch (see 9e9a67e)EDIT: also tested on a live watch over the course of multiple days, it worked great