Correct MCP trust fingerprint, store path, and auth UX - #1017
Merged
TheGreatAxios merged 2 commits intoSep 14, 2026
Merged
Conversation
W1/W2: trust fingerprint covers sorted env key names (never values) with http-when-url-else-stdio type defaulting; store is ~/.corbits/trust/<repo-hash>.json keyed by first 32 hex of SHA-256 of the realpath-canonicalized root. W3: first-run auth is the mcp ! prompt-box mark plus Enter in /mcp opening the URL and auto-copying the link. W4/M1 intentionally skipped per spot-check: no root PLUGINS.md exists, and the briefed slug rule matches session/project-key.ts, not mcp/auth-store.ts.
Collaborator
Author
|
M1 applied (cd9e758): docs/MCP.md now states the exact auth-slug rule per src/mcp/auth-store.ts:42-48 (serverDisplaySlug via legacyServerSlug). W4 decided no-change: docs/PLUGINS.md left untouched. No merge. |
Collaborator
Author
Critic review — docs-only, merge-readySpot-checked every new claim against code. All accurate. Verified
Blocking: none. Nits (non-blocking)
Hygiene: docs text only, 1 file, +11/−8, no behavior change. All CI checks green (build, typecheck, eslint, prettier, tests, static-analysis). Verdict: approve — safe to merge. |
TheGreatAxios
marked this pull request as ready for review
September 14, 2026 04:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Applies verified CL-7899 doc fixes W1–W3 to docs/MCP.md (docs text only, no behavior change). W1: trust fingerprint covers sorted env key names, never values; type defaults http-when-url-else-stdio. W2: store path ~/.corbits/trust/.json, first 32 hex of SHA-256 of realpath-canonicalized root. W3: first-run auth is the mcp ! prompt-box mark; Enter in /mcp opens the URL and auto-copies the link. W4/M1 skipped per spot-check against code: no root PLUGINS.md exists (only docs/PLUGINS.md), and the briefed slug rule matches session/project-key.ts slugSegment, not mcp/auth-store.ts serverDisplaySlug — verifier should re-check those two. Verification: bun run check exit 0 (7307 pass, 0 fail). Fixes CL-7899