Skip to content

Declare emailCode in the useCompleteSignUp example - #770

Merged
Nicolapps merged 1 commit into
rebootfrom
nicolas/doc-fix-complete-sign-up
Oct 21, 2026
Merged

Nicolapps merged 1 commit into
rebootfrom
nicolas/doc-fix-complete-sign-up

Conversation

@Nicolapps

@Nicolapps Nicolapps commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

The useCompleteSignUp example used emailCode without declaring it. This puts the example in a component that takes the code as a prop, like the useCompletePasswordRecovery example.

Found by the doc example check in #763.

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
auth-v2 Ready Ready Preview Oct 21, 2026 1:09am UTC
1 Skipped Deployment
Project Deployment Actions Updated
convex-auth-docs Ignored Ignored Oct 21, 2026 1:09am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@Nicolapps
Nicolapps force-pushed the nicolas/doc-fix-username-passkey branch from 4e2bea6 to b8a064a Compare October 21, 2026 00:49
@Nicolapps
Nicolapps force-pushed the nicolas/doc-fix-complete-sign-up branch from c1d6f6f to 3674a2d Compare October 21, 2026 00:49
@Nicolapps
Nicolapps force-pushed the nicolas/doc-fix-username-passkey branch from b8a064a to 9420ce7 Compare October 21, 2026 00:49
@pkg-pr-new

pkg-pr-new Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@convex-dev/auth@770

commit: c7aeb0a

The example used `emailCode` without a declaration. Put it in a component
that takes the code as a prop.
@Nicolapps
Nicolapps changed the base branch from nicolas/doc-fix-username-passkey to graphite-base/770 October 21, 2026 01:08
@Nicolapps
Nicolapps force-pushed the nicolas/doc-fix-complete-sign-up branch from 31653af to c7aeb0a Compare October 21, 2026 01:08
@Nicolapps
Nicolapps changed the base branch from graphite-base/770 to reboot October 21, 2026 01:08
@Nicolapps
Nicolapps merged commit 80836ba into reboot Oct 21, 2026
10 checks passed

Copy link
Copy Markdown
Member Author

Merge activity

Nicolapps added a commit that referenced this pull request Oct 27, 2026
Vibe-coded a tool to make sure none of our code examples doesn’t compile.

The examples are type-checked against a new empty project used only for typechecking (`packages/doc-examples`)

Adding this tool caught a bunch of issues:
- #767
- #768
- #769
- #770
- #771
- #772
- #773

This branch was successfully deployed

1 active deployment
Preview – auth-v2 — c7aeb0a5 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant