Repository navigation
Fix the httpCookies example - #734
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Nicolapps
marked this pull request as ready for review
October 21, 2026 00:12
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
The example passed `authApi` to ServerAuthSession, which has no such option (it takes `refreshSession`, `cookies` and `cookieOptions`), and it used the result of `refresh()` as a token bundle, while it returns a RefreshResult. Rewrite it with the real config and result shape.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
force-pushed
the
nicolas/ssr-refresh-result-docs
branch
from
October 21, 2026 00:34
14153bb to
b360f3e
Compare
Nicolapps
changed the title
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 21, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 27, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 27, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 27, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 27, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
Nicolapps
added a commit
that referenced
this pull request
Oct 27, 2026
tsc does not read the code in a doc comment, thus the broken httpCookies example fixed in #734 passed every check. Add `pnpm check:doc-examples`, which typechecks each ts/tsx code block in the doc comments of packages/core/src, and run it in CI. The examples compile as modules of packages/doc-examples, a private Convex app that installs every component and sets up every sign-in method, with committed codegen. Thus api, internal, components, env and ctx have their real generated types, and @/auth resolves to its SSR setup. Fix the examples that the check finds: undeclared variables (the OAuth examples now declare their own `auth`, the SSR examples import it from @/auth), pseudo-code JSX, a top-level return, and a wrong import path for `env`.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example on the
httpCookiesreference entry (/api/ssr#httpcookies, also in the shipped.d.ts) didn't compile:authApitoServerAuthSession, which has no such option. It takesrefreshSession,cookiesandcookieOptions.refresh()as a token bundle, butrefresh()returns{ kind: "rotated", tokens } | { kind: "noSession" }.This rewrites the example with the real config and result shape.
Tracking: N-8 (Notion)