Repository navigation
Support findMany offset via cursor pagination - #406
Draft
moritz-mode wants to merge 1 commit into
Draft
moritz-mode wants to merge 1 commit into
moritz-mode wants to merge 1 commit into
Conversation
|
@MauruschatM is attempting to deploy a commit to the Convex Team on Vercel. A member of the Team first needs to authorize it. |
helixnebulatech
added a commit
to helixnebulatech/convex-better-auth
that referenced
this pull request
Oct 8, 2026
findMany threw "offset not supported". Better Auth 1.7.7 passes offset
from the admin plugin's listUsers, which catches the error and returns
{ users: [], total: 0 } for every page after the first, and from the
organization plugin's listMembers, which fails.
The component stays cursor-only: fetch offset + limit rows through the
existing pagination (and the OR union path) and drop the first offset
rows. Re-enables the upstream offset tests; the sortBy variants run in
the additional-fields profile. Ports convex#406.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
findManythrowsoffset not supported, but some Better Auth surfaces passoffset— e.g. the dashboard's table paging. This PR supports it and re-enables the five upstream offset tests in@better-auth/test-utils.Changes
The component paginates by cursor and stays cursor-only. The client fetches
offset + limitrows through the existing cursor pagination and drops the firstoffsetrows;offsetis stripped from the component query args.Cost
offset + limitreads exactlyoffset + limitrows — deep offsets cost proportionally, the same as any cursor-based store emulating offset. This is aimed at admin-style paging.offsetwithoutlimitcan't be rejected (three of the four upstream offset tests passoffsetwith nolimit), but it's cost-equivalent to the already-supported no-limitfindMany, which pages 200 rows at a time to the end — no new unboundedness is introduced.Tests
sortBy and offsetvariants mutate runtime schema (numericFieldadditional field), so they follow the existing pattern: added toADDITIONAL_FIELDS_NORMAL_TESTSand run in the additional-fields profile, which has the static field + index.convex-customtest: offset applied to OR unions.npm run build,npm run typecheck(src), and the full vitest suite pass: 10 files, 188 passed | 26 skipped (main baseline: 182 passed | 31 skipped).Note: this touches the same
findManyregion as #404; whichever merges second will be rebased promptly.