Skip to content

Fix Google sign-in failure with JWT 3 - #95

Merged
philipithomas merged 2 commits into
mainfrom
fix/google-oauth-jwt-verification
Oct 11, 2026
Merged

philipithomas merged 2 commits into
mainfrom
fix/google-oauth-jwt-verification

Conversation

@philipithomas

@philipithomas philipithomas commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Google sign-in fails with uninitialized constant JWT::Verify because omniauth-google-oauth2 1.1.2 calls an API removed in JWT 3. The production error and deployed dependency versions confirm this failure.

Upgrade omniauth-google-oauth2 to 1.2.3, which supports the current JWT claims API, while retaining JWT 3.2.0. Add callback regression coverage using a real authorization-code exchange with stubbed Google responses: successful Workspace identity, invalid and missing claims, verified email handling, opaque access tokens, and OAuth state validation.

Also update Dalli from 3.2.8 to the patched 3.2.13 release and set that security floor. This resolves the six advisories flagged by the required dependency audit while staying on the existing 3.2 release line.

Validation:

  • Reproduced JWT::Verify failures against the deployed 1.1.2 dependency in an isolated Ruby 3.4.10 container.
  • Updated dependency passes all 9 callback tests / 42 assertions in the same isolated runtime.
  • Final CI passed: SOLO (234 tests / 1,730 assertions), MULTIUSER (242 tests / 1,794 assertions), Brakeman, dependency audit, browser checks, and production Docker smoke tests.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T22:47:42.500463Z 3bb591b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@philipithomas
philipithomas merged commit 196102d into main Oct 11, 2026
3 checks passed
@philipithomas
philipithomas deleted the fix/google-oauth-jwt-verification branch October 11, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant