Skip to content

Protect featured posts and hidden-post indexing - #75

Merged
philipithomas merged 8 commits into
mainfrom
codex/postcard-content-privacy
Sep 6, 2026
Merged

philipithomas merged 8 commits into
mainfrom
codex/postcard-content-privacy

Conversation

@philipithomas

@philipithomas philipithomas commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Featured posts now have to belong to the account and be published, unarchived, and visible. Invalid pin requests return a validation error, existing invalid pins are excluded from account and marketing pages without blocking unrelated profile or password updates, and unpublishing a featured post removes its pin. Owned unlisted posts can still be featured.

Hidden posts also send X-Robots-Tag: noindex, nofollow for HTML, Markdown, and image responses while remaining accessible by direct link.

Validation: the complete Rails suite passes in SOLO and MULTIUSER modes (53 tests, 190 assertions in each). New integration/model coverage exercises account isolation, draft and visibility boundaries, historical invalid pins, valid feature updates, and HTML/Markdown indexing behavior.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-06T20:24:46.823715Z 6d89aeb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3db5de2723

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/models/account.rb Resolved
Comment thread app/models/account.rb Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da3e145e67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/models/account.rb Resolved
@philipithomas

Copy link
Copy Markdown
Contributor Author

Resolved the conflicts introduced by main's rollback and subsequent #93 restoration. The privacy guards now coexist with the current image-safety implementation and production cache checks.

Both modes pass 55 tests / 196 assertions on da3e145; all application and production Docker checks are green. The newly reported stale featured-post cache finding is being handled separately in this PR with a regression test.

@philipithomas
philipithomas merged commit 170e6cf into main Sep 6, 2026
3 checks passed
@philipithomas
philipithomas deleted the codex/postcard-content-privacy branch September 6, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant