feat: add Test connection tab to virtual server details drawer - #76
Open
marekdano wants to merge 2 commits into
Open
feat: add Test connection tab to virtual server details drawer#76marekdano wants to merge 2 commits into
marekdano wants to merge 2 commits into
Conversation
Signed-off-by: Marek Dano <mk.dano@gmail.com>
marekdano
force-pushed
the
5650-virtual-server-test-connection
branch
from
August 22, 2026 17:00
6665138 to
5a2c8b3
Compare
… endpoint IBM/mcp-context-forge#6405 replaces the gateway-scoped test-handshake call this panel relied on (which could never succeed for a virtual server, per IBM/mcp-context-forge#6370) with POST /v1/virtual-servers/{id}/test-handshake, which derives its target from the server's own ID instead of a caller-supplied URL. Update HandshakeTestPanel to call the new endpoint by server ID, drop the now-meaningless URL input in favor of a read-only endpoint display, and add the "session" credential source the new endpoint can report. Signed-off-by: Marek Dano <mk.dano@gmail.com>
marekdano
force-pushed
the
5650-virtual-server-test-connection
branch
from
August 25, 2026 11:05
8ee03ff to
e908afd
Compare
marekdano
marked this pull request as ready for review
August 25, 2026 11:06
Contributor
Author
|
This PR can be merged after the PR IBM/mcp-context-forge#6405 is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Test connection" tab to the virtual server details drawer, running an MCP handshake against the virtual server's own endpoint and surfacing the result - negotiation path, server identity, advertised capabilities, credential source used, and component counts cross-checked against the virtual server's own aggregate (flagged on mismatch).
Closes IBM/mcp-context-forge#5650.
Depends on IBM/mcp-context-forge#6405 (fixes IBM/mcp-context-forge#6370) — the original gateway-scoped
POST /v1/mcp-servers/test-handshakeendpoint could never succeed for a virtual server, since its SSRF allowlist only ever matches registered-gateway URLs. #6405 adds a virtual-server-scopedPOST /v1/virtual-servers/{id}/test-handshakeinstead: it derives the test target from the server's own ID and dispatches in-process (no SSRF allowlist involved), reusing the caller's own forwarded session/bearer credentials by default. This PR has been updated to call that endpoint. Still opening as draft — #6405 is open but not yet merged, so full manual end-to-end verification against a running backend is still pending.What's included
src/api/virtualServers.ts—testVirtualServerHandshake()wrapper forPOST /v1/virtual-servers/{id}/test-handshake.src/components/servers/HandshakeTestPanel.tsx— the handshake test panel: read-only endpoint display (the target is now derived server-side from the ID, not caller-supplied, so the URL field is no longer editable), optional header-override form, result rendering (latency, negotiation path, server identity, capabilities, component-count badges with mismatch flagging against the virtual server's aggregate, credential source including the newsessionsource, per-failure-class actionable copy, size-capped raw preview).src/components/gateways/VirtualServerDetailsPanel.tsx— adds the Components / Test connection tab shell (following the #5648 drawer-tab pattern), passes the server's own ID through for the handshake call, and computes+forwards the virtual server's own aggregated tool/resource/prompt counts for mismatch comparison.openapi.json— adds the newPOST /v1/virtual-servers/{server_id}/test-handshakepath andServerHandshakeRequestschema, and extendsGatewayHandshakeResponse.credentialSourcewith the newsessionvalue, matching #6405's backend schema changes.HandshakeTestPanel.test.tsx(idle/success/failure/validation/cancel/unmount/capabilities/credential-source/failure-copy/count-mismatch, including a regression case built from a real backend response) and updated cases inVirtualServerDetailsPanel.test.tsxcovering the tab wiring against the new endpoint.Test plan
npx tsc -b— cleannpm run lint/npm run format:check— cleannpx vitest run— 184 files / 3107 tests passingScreenshots