fix: match sanitized query errors in isPermissionDenied and adopt it in McpHealthCard - #70
Merged
vishu-bh merged 1 commit intoAug 24, 2026
Conversation
…in McpHealthCard useQuery sanitizes thrown ApiErrors into plain objects, so the helper's instanceof check never matched a query error. Make it structural and use it for the McpHealthCard 403 gate. Signed-off-by: Ahmad Al Tamimi <altamimi.dev@gmail.com>
marekdano
approved these changes
Aug 24, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
The PR looks good!
LGTM 🚀
vishu-bh
approved these changes
Aug 24, 2026
vishu-bh
left a comment
vishu-bh
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Altamimi-Dev. LGMT 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65.
McpHealthCardnow usesisPermissionDenied(error)instead of the inlineerror?.status === 403, so new gated cards have one canonical predicate to reuse.One deviation from the issue text: the helper's
instanceof ApiErrornarrowing can never match at this call site.useQuerysanitizes thrown errors into a plain{ message, status, code, body }object (sanitizeErrorinsrc/hooks/useQuery.ts), so the error a card sees is never anApiErrorinstance. Adopting the helper unchanged would have silently broken the PermissionDenied gate; the existing card tests, which mock the sanitized shape, catch exactly this. The helper now does a structuralstatus === 403check, which matches both a rawApiErrorand the sanitized query-error shape, with a doc comment explaining why, plus unit tests.Per the issue's scope note, the domain-specific 403 checks in
loginErrors.ts,passwordResetErrors.tsandchangePasswordRequiredErrors.tsare untouched, as areutils/errors.tsand theuseMiniCardStatusesdefinitive-error classification.