Align Virtual Servers layout with the other components pages - #48
Merged
Merged
Conversation
- Grid becomes `grid-cols-1 / lg:2 / 2xl:3`. `col-span-full` and `sortServersForLayout` both go — cards are uniform now, so empty servers no longer need sorting to the end to keep a full-width row from splitting the grid. Servers render in API order. - Page shell moves from `space-y-9` to a `mb-6` heading, and the loading branch stops early-returning, so the title survives the spinner. - Cards drop `min-h-29` / `min-h-35` and their `justify-*` pairs. - New `--server-icon-bg` token joins `--tool-icon-bg` and `--prompt-icon-bg`; the card status dot stops hardcoding emerald/red and picks up `--tool-status-*`. - `ConnectSourceCard` adopts `AddToolsCard`'s add-icon token, hover and description leading. 2896 tests pass; tsc, eslint, prettier and build are clean. The e2e suite was not run — no local Chromium. Signed-off-by: Anna Effort <anna.effort@ibm.com>
a-effort
requested review from
Yosiefeyob,
gandhipratik203,
gcgoncalves,
marekdano and
vishu-bh
and removed request for
marekdano
August 19, 2026 07:18
gcgoncalves
approved these changes
Aug 19, 2026
a-effort
added a commit
that referenced
this pull request
Aug 19, 2026
- Grid becomes `grid-cols-1 / lg:2 / 2xl:3`. `col-span-full` and `sortServersForLayout` both go — cards are uniform now, so empty servers no longer need sorting to the end to keep a full-width row from splitting the grid. Servers render in API order. - Page shell moves from `space-y-9` to a `mb-6` heading, and the loading branch stops early-returning, so the title survives the spinner. - Cards drop `min-h-29` / `min-h-35` and their `justify-*` pairs. - New `--server-icon-bg` token joins `--tool-icon-bg` and `--prompt-icon-bg`; the card status dot stops hardcoding emerald/red and picks up `--tool-status-*`. - `ConnectSourceCard` adopts `AddToolsCard`'s add-icon token, hover and description leading. 2896 tests pass; tsc, eslint, prettier and build are clean. The e2e suite was not run — no local Chromium. Signed-off-by: Anna Effort <anna.effort@ibm.com>
gcgoncalves
pushed a commit
that referenced
this pull request
Aug 19, 2026
* Adjust tools, resources & prompts light theme Applies PR #34's light-mode pass to the three surfaces it missed. - Status tokens gain a `.dark` override; six sites that hardcoded the emerald/gray shades now use them, including the two server drawers. - Drawer body and right rail both inherit `bg-popover`. The dark-only override they carried split the panes in dark and did nothing in light, where both were pure white. - Scrim `bg-black/10` → `/50` on all five drawers. - The three drawer tables adopt `ServersTable`'s card-per-row pattern, with rows a step down from the drawer body rather than up from the page. Hover and selected are pinned to the row fill. - Page chrome moves to `text-foreground` / `text-muted-foreground`, the off-palette blue spinners are retinted, and two badges stop bypassing the icon tokens. Also fixes an unrelated bug in `VirtualServerDetailsPanel`: the status icon was unconditionally green while its label branched on `enabled`. Forms keep their hardcoded neutrals, matching what PR #34 left behind. 2896 tests pass; tsc, eslint, prettier and build are clean. Signed-off-by: Anna Effort <anna.effort@ibm.com> * fix(ui): restore row hover/selected contrast and drawer rail background Signed-off-by: Marek Dano <mk.dano@gmail.com> * fix(ui): align Users/Teams pagination controls and status icons with theme tokens Signed-off-by: Marek Dano <mk.dano@gmail.com> * Align Virtual Servers layout with the other components pages (#48) - Grid becomes `grid-cols-1 / lg:2 / 2xl:3`. `col-span-full` and `sortServersForLayout` both go — cards are uniform now, so empty servers no longer need sorting to the end to keep a full-width row from splitting the grid. Servers render in API order. - Page shell moves from `space-y-9` to a `mb-6` heading, and the loading branch stops early-returning, so the title survives the spinner. - Cards drop `min-h-29` / `min-h-35` and their `justify-*` pairs. - New `--server-icon-bg` token joins `--tool-icon-bg` and `--prompt-icon-bg`; the card status dot stops hardcoding emerald/red and picks up `--tool-status-*`. - `ConnectSourceCard` adopts `AddToolsCard`'s add-icon token, hover and description leading. 2896 tests pass; tsc, eslint, prettier and build are clean. The e2e suite was not run — no local Chromium. Signed-off-by: Anna Effort <anna.effort@ibm.com> --------- Signed-off-by: Anna Effort <anna.effort@ibm.com> Signed-off-by: Marek Dano <mk.dano@gmail.com> Co-authored-by: Marek Dano <mk.dano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Virtual Servers grid read like Tools / Resources / Prompts.
Changes
grid-cols-1 / lg:2 / 2xl:3.col-span-fullandsortServersForLayoutboth go — cards are uniform now, so empty servers no longer need sorting to the end to keep a full-width row from splitting the grid. Servers render in API order.space-y-9to amb-6heading, and the loading branch stops early-returning, so the title survives the spinner.min-h-29/min-h-35and theirjustify-*pairs.--server-icon-bgtoken joins--tool-icon-bgand--prompt-icon-bg; the card status dot stops hardcoding emerald/red and picks up--tool-status-*.ConnectSourceCardadoptsAddToolsCard's add-icon token, hover and description leading.Notes for review
light-theme-components, notmain: it needsbdeef45for the corrected--tool-status-*shades and the matching drawer fix. Merge that first.CardTagchips is what would make the body itself read like the other three, and that is a separate call.destructivetokens rather than adopting the hardcoded reds the other three pages still carry.Testing
2896 unit tests pass;
tsc -b, eslint, prettier and build are clean.