Skip to content

Improve notification styles #94

Description

@marekdano

Raised by @a-effort in review of #67.

1. Badge success/warning fail AA in light mode. bg-success/15 text-success puts green-600/amber-600 text on its own 15% tint: success 4.57:1 -> 2.79:1, warning 4.58:1 -> 2.71:1, on text-xs badge text needing 4.5:1. Dark mode is fine. One token can't serve both an icon fill (3:1) and text on its own tint (4.5:1); adding --success-foreground/--warning-foreground at the 700 shades for the badge, keeping text-success for icons, would cover both.

2. Two different reds in one form. MCPServerForm.tsx and QueryParameterAuth.tsx move * to text-destructive, but BasicAuth.tsx, OAuth2Auth.tsx (7x) and CustomHeadersAuth.tsx keep text-red-500. AdvancedSettings renders all four as siblings, so both reds show in the same form, and they diverge further in dark mode.

3. Three sibling preview panels missed. Same success/error header as PromptPreviewResult, still on CheckCircle2/AlertCircle: ResourcePreviewResult.tsx:97 (also text-emerald-500), ToolPreviewResult.tsx:61, ToolLiveInvokeResult.tsx:57. All present at the merge base.

4. Info notifications drop below AA. inline-notification.tsx applies STATUS_TONE_CLASS.info (text-muted-foreground) to the message as well as the icon: 5.17:1 -> 3.45:1 in light mode. Unaccented is right for the icon; the <p> could stay text-foreground.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions