You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR addresses #266 and #8 . It adds an optional boolean, useRelativeCwd to the mdx config. When set to true the cwd will be set to the directory the file currently being processed resides in.
I've included a test which will attempt to bundle a relatively-linked image from an mdx file.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@schickling Because MDX Bundler has it's own cwd option I've left that as-is, allowing the user to set any arbitrary path they want.
contentlayer now supports a resolveCwd option which is a union of relative and contentDirPath options. If neither cwd nor resolveCwd are provided then the new relative behavior is used as the default. If the user prefers the current behavior they can use the contentDirPath option.
This will be a breaking change for some users when using the default. If an mdx import was defined relative to the contentDirPath and the file being processed was at, say, content/posts/post.mdx then the imports would change as follows:
Before:
import { Widget } from '../components/Widget'
After:
import { Widget } from '../../components/Widget'
If the user had a flat content directory, say all their files in the root of contentDirPath (content/post.mdx) then there would be no change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #266 and #8 . It adds an optional boolean,
useRelativeCwdto themdxconfig. When set to true thecwdwill be set to the directory the file currently being processed resides in.I've included a test which will attempt to bundle a relatively-linked image from an
mdxfile.