Skip to content

Revert "oci-validation: checkout last working commit for runtime-tools" - #831

Merged
giuseppe merged 2 commits into
containers:mainfrom
kolyshkin:test-runtime-tools
Jan 11, 2022
Merged

Revert "oci-validation: checkout last working commit for runtime-tools"#831
giuseppe merged 2 commits into
containers:mainfrom
kolyshkin:test-runtime-tools

Conversation

@kolyshkin

@kolyshkin kolyshkin commented Jan 4, 2022

Copy link
Copy Markdown
Collaborator

Since opencontainers/runtime-tools#741 and opencontainers/runtime-tools#742 this is no longer needed.

This reverts commit 6d046d6 (PR #762).

Currently a draft, pending opencontainers/runtime-tools#742 merge.

@kolyshkin

This comment has been minimized.

@kolyshkin
kolyshkin marked this pull request as draft January 4, 2022 22:17
@kolyshkin

This comment has been minimized.

@kolyshkin kolyshkin closed this Jan 5, 2022
@kolyshkin kolyshkin reopened this Jan 5, 2022
@rhatdan

rhatdan commented Jan 7, 2022

Copy link
Copy Markdown
Member

@kolyshkin Might need to rebase and repush.

@kolyshkin
kolyshkin force-pushed the test-runtime-tools branch 3 times, most recently from 6f1bf24 to 290bcec Compare January 8, 2022 19:28
@giuseppe

Copy link
Copy Markdown
Member

@kir is this still a Draft?

@kolyshkin
kolyshkin marked this pull request as ready for review January 10, 2022 23:49
@kolyshkin

Copy link
Copy Markdown
Collaborator Author

@kir is this still a Draft?

No longer (just had opencontainers/runtime-tools#742 merged).

@kolyshkin

Copy link
Copy Markdown
Collaborator Author

Fuzzing failure is a recent regression; should be fixed by #844

Since opencontainers/runtime-tools#741 this is
no longer needed.

This reverts commit 6d046d6.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Instead of building everything, let's only build what we need.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
giuseppe merged commit 568a98d into containers:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants