seccomp: support notify listener#627
Merged
Merged
Conversation
Member
Author
giuseppe
force-pushed
the
seccomp-notifications-oci
branch
3 times, most recently
from
March 17, 2021 13:10
b649c17 to
1187828
Compare
giuseppe
marked this pull request as ready for review
March 17, 2021 13:16
giuseppe
force-pushed
the
seccomp-notifications-oci
branch
4 times, most recently
from
March 23, 2021 11:56
1ecc6ba to
09ddd93
Compare
Member
Author
|
rebased |
rhatdan
approved these changes
Mar 23, 2021
| /* | ||
| * crun - OCI runtime written in C | ||
| * | ||
| * Copyright (C) 2018, 2019 Giuseppe Scrivano <giuseppe@scrivano.org> |
Member
There was a problem hiding this comment.
Does this need to be updated/changed?
rhatdan
reviewed
Mar 23, 2021
|
|
||
| yajl_gen_string (gen, YAJL_STR ("pid"), strlen ("pid")); | ||
| yajl_gen_integer (gen, pid); | ||
| r = yajl_gen_string (gen, YAJL_STR ("1.0"), strlen ("1.0")); |
Member
There was a problem hiding this comment.
Should you hard code the version here?
rhatdan
reviewed
Mar 23, 2021
| if (UNLIKELY (r != yajl_gen_status_ok)) | ||
| goto exit; | ||
|
|
||
| r = yajl_gen_string (gen, YAJL_STR ("0.2.0"), strlen ("0.2.0")); |
Member
There was a problem hiding this comment.
Majic number, should this be a const?
rhatdan
reviewed
Mar 23, 2021
| if (UNLIKELY (r != yajl_gen_status_ok)) | ||
| goto exit; | ||
|
|
||
| r = yajl_gen_string (gen, YAJL_STR ("0.2.0"), strlen ("0.2.0")); |
rhatdan
reviewed
Mar 23, 2021
| if (strcmp (argv[1], "check-feature") == 0) | ||
| { | ||
| if (argc < 2) | ||
| if (argc <= 2) |
Member
There was a problem hiding this comment.
Should this be just 3, would be easier to understand.
giuseppe
force-pushed
the
seccomp-notifications-oci
branch
2 times, most recently
from
March 23, 2021 17:32
c978989 to
1cac654
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
The OCI runtime specs[1] recently gained the support for seccomp notifications. [1] opencontainers/runtime-spec#1074 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
seccomp-notifications-oci
branch
from
March 23, 2021 18:58
1cac654 to
9aa382b
Compare
Member
Author
|
addressed the comments and pushed a new version |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OCI runtime specs[1] recently gained the support for seccomp
notifications.
[1] opencontainers/runtime-spec#1074
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com