Skip to content

status: fix double-close#2137

Merged
giuseppe merged 1 commit into
containers:mainfrom
eriksjolund:fix-double-close
Jul 15, 2026
Merged

status: fix double-close#2137
giuseppe merged 1 commit into
containers:mainfrom
eriksjolund:fix-double-close

Conversation

@eriksjolund

Copy link
Copy Markdown
Contributor

Fixes: #2136

Fixes: containers#2136

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates src/libcrun/status.c to set cfd to -1 after passing it to rmdirfd, clarifying ownership of the file descriptor and preventing potential double-close issues. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kolyshkin kolyshkin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit fb54bc0 into containers:main Jul 15, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

status: file descriptor closed twice

3 participants